[llvm-commits] [llvm] r126964 - in /llvm/trunk: lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp lib/CodeGen/SelectionDAG/LegalizeTypes.h test/CodeGen/X86/umulo-64.ll

Eric Christopher echristo at apple.com
Thu Mar 3 16:16:47 PST 2011


> Err, I'm reasonably sure the code has precisely the same issues for
> 64-bit... narrow my previous example and compile on x86-32, and you
> end up with the following, which has the exact same issue:

So I was trying to be clever and have no idea what I was thinking. :)

Here's a simple patch that fixes the problem in something resembling correctness, but uses divide to do it - so yeah, performance?

Thoughts?

-eric

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: legalize.diff.txt
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110303/f9d30552/attachment.txt>


More information about the llvm-commits mailing list