[llvm-commits] [llvm] r126964 - in /llvm/trunk: lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp lib/CodeGen/SelectionDAG/LegalizeTypes.h test/CodeGen/X86/umulo-64.ll

[Eric Christopher]

>> 
>> Aha. I'd only been testing 64-bit on arm, not 128-bit on x86-64. Though, what happens on x86-64 without the patch applied? It can't possibly succeed and be correct?
>> 
>> I'll take a look at it, but I'm pretty sure the code works for 64-bit. Probably could hack it to turn off if there's no multiply instruction for the target at the width.
> 
> Err, I'm reasonably sure the code has precisely the same issues for
> 64-bit... narrow my previous example and compile on x86-32, and you
> end up with the following, which has the exact same issue:

Was just doing that.

Thanks

-eric