[llvm-commits] [llvm] r121166 - /llvm/trunk/utils/TableGen/FastISelEmitter.cpp

[Eric Christopher]

On Dec 7, 2010, at 11:35 AM, Jim Grosbach wrote:

> Author: grosbach
> Date: Tue Dec  7 13:35:36 2010
> New Revision: 121166
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=121166&view=rev
> Log:
> Change assert to diagnostic. Message still needs work, but it's better than
> an assert, at least.
> 
>     };
> -    assert(!SimplePatterns[Operands][OpcodeName][VT][RetVT]
> -            .count(PredicateCheck) &&
> -           "Duplicate pattern!");
> +    // FIXME: Source location information for the diagnostic.
> +    if (SimplePatterns[Operands][OpcodeName][VT][RetVT]
> +            .count(PredicateCheck)) {
> +      SmallString<128> PatText;
> +      raw_svector_ostream OS(PatText);
> +      Pattern.SrcPattern->print(OS);
> +      throw "Duplicate record: " + OS.str().str();
> +    }
>     SimplePatterns[Operands][OpcodeName][VT][RetVT][PredicateCheck] = Memo;
>   }
> }

Hmm? What's going on here?

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101207/bd813bd1/attachment.html>