<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Dec 7, 2010, at 11:35 AM, Jim Grosbach wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Author: grosbach<br>Date: Tue Dec 7 13:35:36 2010<br>New Revision: 121166<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=121166&view=rev">http://llvm.org/viewvc/llvm-project?rev=121166&view=rev</a><br>Log:<br>Change assert to diagnostic. Message still needs work, but it's better than<br>an assert, at least.<br><br> };<br>- assert(!SimplePatterns[Operands][OpcodeName][VT][RetVT]<br>- .count(PredicateCheck) &&<br>- "Duplicate pattern!");<br>+ // FIXME: Source location information for the diagnostic.<br>+ if (SimplePatterns[Operands][OpcodeName][VT][RetVT]<br>+ .count(PredicateCheck)) {<br>+ SmallString<128> PatText;<br>+ raw_svector_ostream OS(PatText);<br>+ Pattern.SrcPattern->print(OS);<br>+ throw "Duplicate record: " + OS.str().str();<br>+ }<br> SimplePatterns[Operands][OpcodeName][VT][RetVT][PredicateCheck] = Memo;<br> }<br> }<br></div></blockquote></div><br><div>Hmm? What's going on here?</div><div><br></div><div>-eric</div></body></html>