[llvm-commits] Fix output stream opened in text instead of binary mode on MinGW

[Danil Malyshev]

Hi NAKAMURA,

Thanks for your remark. I redid the test for the use of cmp, I also redid the test extract.ll to use cmp instead of diff. The new patch is attached.


Thank you,
Danil


-----Original Message-----
From: NAKAMURA Takumi [mailto:geek4civic at gmail.com] 
Sent: Wednesday, December 01, 2010 3:18 AM
To: Danil Malyshev
Cc: Chris Lattner; llvm-commits LLVM
Subject: Re: [llvm-commits] Fix output stream opened in text instead of binary mode on MinGW

Committed in r120506, thank you!

2010/12/1 Danil Malyshev <dmalyshev at accesssoftek.com>:
> However, they will not catch the "output stream opened in wrong mode" issue.
> llvm-ar produce binary output and this should be tested.
> I propose a test to check this. The patch is attached.

I have no concrete patches now, though, using diff(1) for binary files
would not be better idea(on win32), IMHO.

  - use cmp(1)
  - use llvm's opt to verify.
  - use md5sum sha1sum or similar.

...Takumi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test-archive-binary-output-02.diff
Type: application/octet-stream
Size: 1697 bytes
Desc: test-archive-binary-output-02.diff
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101201/de9450ab/attachment.obj>