[llvm-commits] Fix output stream opened in text instead of binary mode on MinGW

NAKAMURA Takumi geek4civic at gmail.com
Tue Nov 30 16:18:07 PST 2010


Committed in r120506, thank you!

2010/12/1 Danil Malyshev <dmalyshev at accesssoftek.com>:
> However, they will not catch the "output stream opened in wrong mode" issue.
> llvm-ar produce binary output and this should be tested.
> I propose a test to check this. The patch is attached.

I have no concrete patches now, though, using diff(1) for binary files
would not be better idea(on win32), IMHO.

  - use cmp(1)
  - use llvm's opt to verify.
  - use md5sum sha1sum or similar.

...Takumi



More information about the llvm-commits mailing list