[llvm-commits] [Review request] Add the feature "sh" for LLVM::Other/close-stderr.ll, for MSVC

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Nov 29 15:53:28 PST 2010


> It *succeeds unexpected* on MSYS-mingw bash. :)
> IMHO I prefer to avoid XFAIL as possible.

I see, and I take there is no way to XFAIL this on "regular" Windows
but not mingw.

I am no shell expert. Chandler, is there a portable way to cause
stderr to be closed? We could write this in python, but having an
extra script for just for this test is bad too.

If no one has a better idea, the patch is fine. Just use a more
descriptive name like "posix_shell" or just "shell" :-)

> ps. my all proposals are;
> https://github.com/chapuni/llvm-mirror/tree/msys-shared
> (excuse me, some commits have Japanese logs)
>
> ...Takumi
>

Cheers,
Rafael



More information about the llvm-commits mailing list