[llvm-commits] [Review request] Add the feature "sh" for LLVM::Other/close-stderr.ll, for MSVC

NAKAMURA Takumi geek4civic at gmail.com
Mon Nov 29 13:59:16 PST 2010


Good morning, Rafael.

2010/11/30 Rafael Espíndola <rafael.espindola at gmail.com>:
>>  Activate the feature.
>
> A feature for one test? Isn't it better to use XFAIL?

It *succeeds unexpected* on MSYS-mingw bash. :)
IMHO I prefer to avoid XFAIL as possible.

ps. my all proposals are;
https://github.com/chapuni/llvm-mirror/tree/msys-shared
(excuse me, some commits have Japanese logs)

...Takumi




More information about the llvm-commits mailing list