[llvm-commits] Fix output stream opened in text instead of binary mode on MinGW

[Chris Lattner]

On Nov 29, 2010, at 11:38 AM, Danil Malyshev wrote:

> Hello Jakob,
>  
> > Can you find a way of doing this without increasing the size of the raw_ostream object, and without imposing any overhead on users that don't need it?
>  
> Ok, I did it.
> Attached file fix-cout-02.diff is the new patch. It change only llvm-ar, llvm-ranlib, and attributes of *.toc files in Archive tests.

The llvm-ar and llvm-ranlib changes look great, committed in r120341.  I also removed the #include of <iostream>, saving us a static ctor.

I don't understand or have an opinion on the archive tests though, can you explain it more?  Can someone on windows review them?

-Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101129/e50ad696/attachment.html>