[llvm-commits] Fix output stream opened in text instead of binary mode on MinGW

Jakob Stoklund Olesen stoklund at 2pi.dk
Mon Nov 29 11:44:20 PST 2010


On Nov 29, 2010, at 11:38 AM, Danil Malyshev wrote:

> Hello Jakob,
>  
> > Can you find a way of doing this without increasing the size of the raw_ostream object, and without imposing any overhead on users that don't need it?
>  
> Ok, I did it.
> Attached file fix-cout-02.diff is the new patch. It change only llvm-ar, llvm-ranlib, and attributes of *.toc files in Archive tests.

That is much better, thanks!

Somebody else should have an opinion about how we handle newlines and binary files in SVN on Windows.

/jakob





More information about the llvm-commits mailing list