[llvm-commits] [llvm] r119853 - /llvm/trunk/lib/Transforms/Scalar/CodeGenPrepare.cpp

Chris Lattner clattner at apple.com
Sat Nov 20 09:49:19 PST 2010


On Nov 20, 2010, at 12:24 AM, Duncan Sands wrote:

> Hi Owen,
> 
>> When folding addressing modes in CodeGenPrepare, attempt to look through PHI nodes
>> if all the operands of the PHI are equivalent.  This allows CodeGenPrepare to undo
>> unprofitable PRE transforms.
> 
> I think I understood this patch now, sorry for the noise.

Owen, please add comments to address Duncan's confusion.  If he "didn't get it" reading the code, then some more comments would definitely be useful :)

Thanks!

-Chris



More information about the llvm-commits mailing list