[llvm-commits] [PATCH] Bug in DAG Combine for ARM shift

Bob Wilson bob.wilson at apple.com
Thu Nov 18 11:58:27 PST 2010

On Nov 18, 2010, at 11:48 AM, Eric Christopher wrote:

> On Nov 17, 2010, at 7:30 PM, Tanya Lattner wrote:
>> Attached is a patch and test case for a bug in PerformShiftCombine() when operating on illegal types for shift right/left immediate. 
>> Please review and let me know if its ok to commit.
> Looks fine to me.

I agree, but it would be a little bit simpler to check for legal types earlier.  See attached.  Either way, whichever you prefer.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: shiftCombine.patch
Type: application/octet-stream
Size: 573 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101118/a0ee3e1c/attachment.obj>

More information about the llvm-commits mailing list