[llvm-commits] [PATCH] Bug in DAG Combine for ARM shift

[Tanya Lattner]

Thanks for all the reviews. I've made the change Bob suggested and will commit.

-Tanya

On Nov 18, 2010, at 11:58 AM, Bob Wilson wrote:

> 
> On Nov 18, 2010, at 11:48 AM, Eric Christopher wrote:
> 
>> 
>> On Nov 17, 2010, at 7:30 PM, Tanya Lattner wrote:
>> 
>>> Attached is a patch and test case for a bug in PerformShiftCombine() when operating on illegal types for shift right/left immediate. 
>>> 
>>> Please review and let me know if its ok to commit.
>> 
>> Looks fine to me.
> 
> I agree, but it would be a little bit simpler to check for legal types earlier.  See attached.  Either way, whichever you prefer.
> 
> <shiftCombine.patch>