[llvm-commits] Proof of concept patch for unifying the .s/ELF emission of .ARM.attributes

[Jason Kim]

On Wed, Oct 20, 2010 at 8:11 AM, Rafael Espíndola
<rafael.espindola at gmail.com> wrote:
> missing that some of the variables were *fully* unused or just
> initialized to NULL.

Yikes! Thanks for catching the leftover counters.
Hmm, the other MCDataFragment ptrs are there for making future work
explicit, replacing them with comments is fine too.

Tho I don't quite agree that moving the headFragment to a local var
makes the code really better,
but given that I missed the above, I'll go with your suggestion.
Here's the modified patch - very similar to your rework, plus a NULL
cleanup, some whitespace nits, with the test re-added.

> The attached patch is a modified version of yours that illustrates
> some of the issues.

Gosh, this is taking a while :-)
Is there anything else I missed?

Thanks!

-jason
-------------- next part --------------
A non-text attachment was scrubbed...
Name: arm-mc-elf-s06-mod.patch2
Type: application/octet-stream
Size: 12690 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101020/2acc70e9/attachment.obj>