[llvm-commits] Proof of concept patch for unifying the .s/ELF emission of .ARM.attributes

[Rafael Espíndola]

> Gosh, this is taking a while :-)
> Is there anything else I missed?

Another one I noticed. Instead of

      SmallString<32> *FC = &currFileFragment.getContents();
      (*FC) += static_cast<char>(attr);
      (*FC) += static_cast<char>(0xFF & v);

You can do

     OutStreamer.EmitIntValue(static_cast<char>(attr), 1);
     OutStreamer.EmitIntValue(0xFF & v, 1);

No? Using the streamer interface looks a lot more in line with what
the rest of the code does.

> Thanks!
>
> -jason
>

Cheers,
Rafael