[llvm-commits] PATCH: llvm-gcc option to emit "va_arg" instruction

[Chris Lattner]

On Oct 11, 2010, at 7:44 AM, David Meyer wrote:

> I discovered I was missing some #ifdef's.
> 
> New patch is attached.
> 
> Updated visual at: http://codereview.chromium.org/3694002/show

Hi David,

I haven't looked at the patch, but I'm not in favor of this.  Having llvm-gcc generate the va_arg instruction (on targets where it works) is goodness, but we shouldn't add a user-visible knob for it.  We should just *always* generate it on those targets.

-Chris

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101011/33cdff02/attachment.html>