<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Oct 11, 2010, at 7:44 AM, David Meyer wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">I discovered I was missing some #ifdef's.<div><br></div><div>New patch is attached.</div><div><br></div><div>Updated visual at: <a href="http://codereview.chromium.org/3694002/show">http://codereview.chromium.org/3694002/show</a></div>
</blockquote><br></div><div>Hi David,</div><div><br></div><div>I haven't looked at the patch, but I'm not in favor of this. Having llvm-gcc generate the va_arg instruction (on targets where it works) is goodness, but we shouldn't add a user-visible knob for it. We should just *always* generate it on those targets.</div><div><br></div><div>-Chris</div><br></body></html>