[llvm-commits] [patch] Fix va_arg for double and some cleanups

[Dan Gohman]

On Jul 9, 2010, at 3:25 PM, Rafael Espindola wrote:

>> But it's not the stack pointer itself that you care about here, it's the
>> alignment of whatever the prior argument was. So you really want to know
>> "What's the least alignment of any argument?" That's why I thought
>> getCallFrameTypeAlignment would work. If it's not returning the right
>> value, that may be a bug.
> 
> On IRC we agreed that we need yet another alignment type :-(
> 
> The attached patch adds MinStackArgumentAlignment to
> TargetLoweringInfo and uses that. I also extended the test a bit to
> check that only the necessary alignment is added.

This patch looks good to me.

Thanks,

Dan