[llvm-commits] [patch] Fix va_arg for double and some cleanups

Rafael Espindola espindola at google.com
Fri Jul 9 15:25:25 PDT 2010


> But it's not the stack pointer itself that you care about here, it's the
> alignment of whatever the prior argument was. So you really want to know
> "What's the least alignment of any argument?" That's why I thought
> getCallFrameTypeAlignment would work. If it's not returning the right
> value, that may be a bug.

On IRC we agreed that we need yet another alignment type :-(

The attached patch adds MinStackArgumentAlignment to
TargetLoweringInfo and uses that. I also extended the test a bit to
check that only the necessary alignment is added.

> Dan
>
>

Cheers,
-- 
Rafael Ávila de Espíndola
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vaarg.patch
Type: text/x-patch
Size: 8267 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100709/a37091f5/attachment.bin>


More information about the llvm-commits mailing list