[llvm-commits] Buggy SelectionDAG binop vector widening

Mon Ping Wang wangmp at apple.com
Wed Jun 9 09:31:32 PDT 2010


I'll take a look as well.

  -- Mon Ping

On Jun 8, 2010, at 11:32 PM, Duncan Sands wrote:

> Hi Dale,
> 
>>> Thanks for the advice. I changed all three occurances of isTypeLegal to
>>> isTypeSynthesizable in DAGTypeLegalizer::WidenVecRes_Binary. There are
>>> still six other isTypeLegal call sites in LegalizeVectorTypes.cpp that
>>> probably should be updated, but I didn't touch those for now. The
>>> updated patch is attached.
>> 
>> It looks OK to me but I am not expert in this code. Duncan, you wrote
>> this didn't you? Can you look?
> 
> Mon Ping wrote the vector widening stuff.  I will try to take a look too.
> 
> Ciao,
> 
> Duncan.




More information about the llvm-commits mailing list