[llvm-commits] Buggy SelectionDAG binop vector widening

Duncan Sands baldrick at free.fr
Tue Jun 8 23:32:03 PDT 2010


Hi Dale,

>> Thanks for the advice. I changed all three occurances of isTypeLegal to
>> isTypeSynthesizable in DAGTypeLegalizer::WidenVecRes_Binary. There are
>> still six other isTypeLegal call sites in LegalizeVectorTypes.cpp that
>> probably should be updated, but I didn't touch those for now. The
>> updated patch is attached.
>
> It looks OK to me but I am not expert in this code. Duncan, you wrote
> this didn't you? Can you look?

Mon Ping wrote the vector widening stuff.  I will try to take a look too.

Ciao,

Duncan.



More information about the llvm-commits mailing list