[llvm-commits] [llvm] r94400 - in /llvm/trunk: lib/Target/ARM/ARMMCAsmInfo.cpp test/CodeGen/ARM/align.ll test/CodeGen/ARM/globals.ll

[Chris Lattner]

On Jan 24, 2010, at 6:27 PM, Rafael Espindola wrote:

> Author: rafael
> Date: Sun Jan 24 20:27:39 2010
> New Revision: 94400
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=94400&view=rev
> Log:
> Fix PR6134.
> We are not emitting alignments on Darwin for "bar". Not sure what is the
> correct way to do it.

This is almost certainly a bug:

ARMMCAsmInfoDarwin::ARMMCAsmInfoDarwin() {
...
  COMMDirectiveTakesAlignment = false;

Jim, can you see if the darwin assembler accepts _bar with this line removed?  If so, please remove it.

-Chris



> 
> + at bar = common global [75 x i8] zeroinitializer, align 128
> +;ELF: .comm bar,75,128
> +; no alignment on darwin?
> +;DARWIN: .comm _bar,75
> 
> Modified: llvm/trunk/test/CodeGen/ARM/globals.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/globals.ll?rev=94400&r1=94399&r2=94400&view=diff
> 
> ==============================================================================
> --- llvm/trunk/test/CodeGen/ARM/globals.ll (original)
> +++ llvm/trunk/test/CodeGen/ARM/globals.ll Sun Jan 24 20:27:39 2010
> @@ -67,9 +67,9 @@
> ; LinuxPIC: 	ldr r0, [r0]
> ; LinuxPIC: 	bx lr
> 
> -; LinuxPIC: .align 2
> +; LinuxPIC: .align 4
> ; LinuxPIC: .LCPI1_0:
> ; LinuxPIC:     .long _GLOBAL_OFFSET_TABLE_-(.LPC1_0+8)
> -; LinuxPIC: .align 2
> +; LinuxPIC: .align 4
> ; LinuxPIC: .LCPI1_1:
> ; LinuxPIC:     .long	G(GOT)
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits