[llvm-commits] [llvm] r94400 - in /llvm/trunk: lib/Target/ARM/ARMMCAsmInfo.cpp test/CodeGen/ARM/align.ll test/CodeGen/ARM/globals.ll

[Rafael Espindola]

Author: rafael
Date: Sun Jan 24 20:27:39 2010
New Revision: 94400

URL: http://llvm.org/viewvc/llvm-project?rev=94400&view=rev
Log:
Fix PR6134.
We are not emitting alignments on Darwin for "bar". Not sure what is the
correct way to do it.


Modified:
    llvm/trunk/lib/Target/ARM/ARMMCAsmInfo.cpp
    llvm/trunk/test/CodeGen/ARM/align.ll
    llvm/trunk/test/CodeGen/ARM/globals.ll

Modified: llvm/trunk/lib/Target/ARM/ARMMCAsmInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMMCAsmInfo.cpp?rev=94400&r1=94399&r2=94400&view=diff

==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMMCAsmInfo.cpp (original)
+++ llvm/trunk/lib/Target/ARM/ARMMCAsmInfo.cpp Sun Jan 24 20:27:39 2010
@@ -53,11 +53,9 @@
 }
 
 ARMELFMCAsmInfo::ARMELFMCAsmInfo() {
-  AlignmentIsInBytes = false;
   Data64bitsDirective = 0;
   CommentString = "@";
-  COMMDirectiveTakesAlignment = false;
-  
+
   NeedsSet = false;
   HasLEB128 = true;
   AbsoluteDebugSectionOffsets = true;

Modified: llvm/trunk/test/CodeGen/ARM/align.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/align.ll?rev=94400&r1=94399&r2=94400&view=diff

==============================================================================
--- llvm/trunk/test/CodeGen/ARM/align.ll (original)
+++ llvm/trunk/test/CodeGen/ARM/align.ll Sun Jan 24 20:27:39 2010
@@ -1,15 +1,43 @@
-; RUN: llc < %s -march=arm | grep align.*1 | count 1
-; RUN: llc < %s -mtriple=arm-linux-gnueabi | \
-; RUN:   grep align.*2 | count 2
-; RUN: llc < %s -mtriple=arm-linux-gnueabi | \
-; RUN:   grep align.*3 | count 2
-; RUN: llc < %s -mtriple=arm-apple-darwin | \
-; RUN:   grep align.*2 | count 4
+; RUN: llc < %s -mtriple=arm-linux-gnueabi | FileCheck %s -check-prefix=ELF
+; RUN: llc < %s -mtriple=arm-apple-darwin | FileCheck %s -check-prefix=DARWIN
 
 @a = global i1 true
+; no alignment
+
 @b = global i8 1
+; no alignment
+
 @c = global i16 2
+;ELF: .align 2
+;ELF: c:
+;DARWIN: .align 1
+;DARWIN: _c:
+
 @d = global i32 3
+;ELF: .align 4
+;ELF: d:
+;DARWIN: .align 2
+;DARWIN: _d:
+
 @e = global i64 4
+;ELF: .align 8
+;ELF: e
+;DARWIN: .align 2
+;DARWIN: _e:
+
 @f = global float 5.0
+;ELF: .align 4
+;ELF: f:
+;DARWIN: .align 2
+;DARWIN: _f:
+
 @g = global double 6.0
+;ELF: .align 8
+;ELF: g:
+;DARWIN: .align 2
+;DARWIN: _g:
+
+ at bar = common global [75 x i8] zeroinitializer, align 128
+;ELF: .comm bar,75,128
+; no alignment on darwin?
+;DARWIN: .comm _bar,75

Modified: llvm/trunk/test/CodeGen/ARM/globals.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/globals.ll?rev=94400&r1=94399&r2=94400&view=diff

==============================================================================
--- llvm/trunk/test/CodeGen/ARM/globals.ll (original)
+++ llvm/trunk/test/CodeGen/ARM/globals.ll Sun Jan 24 20:27:39 2010
@@ -67,9 +67,9 @@
 ; LinuxPIC: 	ldr r0, [r0]
 ; LinuxPIC: 	bx lr
 
-; LinuxPIC: .align 2
+; LinuxPIC: .align 4
 ; LinuxPIC: .LCPI1_0:
 ; LinuxPIC:     .long _GLOBAL_OFFSET_TABLE_-(.LPC1_0+8)
-; LinuxPIC: .align 2
+; LinuxPIC: .align 4
 ; LinuxPIC: .LCPI1_1:
 ; LinuxPIC:     .long	G(GOT)