[llvm-commits] [llvm] r93456 - /llvm/trunk/lib/CodeGen/LLVMTargetMachine.cpp

[Jim Grosbach]

On Jan 14, 2010, at 1:35 PM, Eric Christopher wrote:

>>
>> Dwarf EH prepare needs to be run after SjLj prepare. Otherwise,
>> catch info can get misplaced when a selector ends up more than one  
>> block
>> removed from the parent invoke(s). This could happen when a landing  
>> pad is
>> shared by multiple invokes and is also a target of a normal edge from
>> elsewhere.
>>
>>    // SjLj piggy-backs on dwarf for this bit. The cleanups done  
>> apply to both
>> -    PM.add(createDwarfEHPass(getTargetLowering(),  
>> OptLevel==CodeGenOpt::None));
>>    PM.add(createSjLjEHPass(getTargetLowering()));
>> +    PM.add(createDwarfEHPass(getTargetLowering(),  
>> OptLevel==CodeGenOpt::None));
>
> Can you please add a comment to this effect?
>

Good point. Definitely worth some exposition. Done in r93459.

> Thanks!
>
> -eric