[llvm-commits] [llvm] r93456 - /llvm/trunk/lib/CodeGen/LLVMTargetMachine.cpp

Eric Christopher echristo at apple.com
Thu Jan 14 13:35:49 PST 2010


> 
> Dwarf EH prepare needs to be run after SjLj prepare. Otherwise,
> catch info can get misplaced when a selector ends up more than one block
> removed from the parent invoke(s). This could happen when a landing pad is
> shared by multiple invokes and is also a target of a normal edge from
> elsewhere.
> 
>     // SjLj piggy-backs on dwarf for this bit. The cleanups done apply to both
> -    PM.add(createDwarfEHPass(getTargetLowering(), OptLevel==CodeGenOpt::None));
>     PM.add(createSjLjEHPass(getTargetLowering()));
> +    PM.add(createDwarfEHPass(getTargetLowering(), OptLevel==CodeGenOpt::None));

Can you please add a comment to this effect?

Thanks!

-eric



More information about the llvm-commits mailing list