[llvm-commits] [llvm] r92761 - in /llvm/trunk: docs/LangRef.html include/llvm/Metadata.h lib/AsmParser/LLParser.cpp lib/Bitcode/Reader/BitcodeReader.cpp lib/VMCore/Metadata.cpp unittests/VMCore/MetadataTest.cpp

[Chris Lattner]

On Jan 8, 2010, at 4:30 PM, Devang Patel wrote:

>
> On Jan 8, 2010, at 11:45 AM, Chris Lattner wrote:
>
>>> +++ llvm/trunk/include/llvm/Metadata.h Tue Jan  5 14:41:31 2010
>>> @@ -167,7 +167,7 @@
>>> };
>>>
>>> // 
>>> = 
>>> = 
>>> = 
>>> ----------------------------------------------------------------------= 
>>> ==//
>>> -/// NamedMDNode - a tuple of other metadata.
>>> +/// NamedMDNode - a tuple of MDNodes.
>>> /// NamedMDNode is always named. All NamedMDNode operand has a  
>>> type of metadata.
>>> class NamedMDNode : public MetadataBase, public  
>>> ilist_node<NamedMDNode> {
>>
>> This should inherit from Value, not MetadataBase.
>>
>
> ( ... but it is still a metadata! )

It contains metadata, but it is not metdata.

-Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100108/7ebd89ba/attachment.html>