<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jan 8, 2010, at 4:30 PM, Devang Patel wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jan 8, 2010, at 11:45 AM, Chris Lattner wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Verdana; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><blockquote type="cite">+++ llvm/trunk/include/llvm/Metadata.h Tue Jan 5 14:41:31 2010<br></blockquote><blockquote type="cite">@@ -167,7 +167,7 @@<br></blockquote><blockquote type="cite">};<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">//===----------------------------------------------------------------------===//<br></blockquote><blockquote type="cite">-/// NamedMDNode - a tuple of other metadata.<br></blockquote><blockquote type="cite">+/// NamedMDNode - a tuple of MDNodes.<br></blockquote><blockquote type="cite">/// NamedMDNode is always named. All NamedMDNode operand has a type of metadata.<br></blockquote><blockquote type="cite">class NamedMDNode : public MetadataBase, public ilist_node<NamedMDNode> {<br></blockquote><br>This should inherit from Value, not MetadataBase.<br><font class="Apple-style-span" color="#000000"><font class="Apple-style-span" color="#144FAE"><br></font></font></span></blockquote><div><br></div>( ... but it is still a metadata! )</div></div></blockquote></div><br><div>It contains metadata, but it is not metdata.</div><div><br></div><div>-Chris</div></body></html>