[llvm-commits] [llvm] r88830 - in /llvm/trunk: lib/Transforms/Scalar/InstructionCombining.cpp test/Transforms/InstCombine/compare-signs.ll

[Nick Lewycky]

Duncan Sands wrote:
> Hi Nick,
>
>> + if (KnownZeroLHS.countLeadingOnes() == BitWidth-1 &&
>> + KnownZeroRHS.countLeadingOnes() == BitWidth-1) {
>
> don't you want >= here, in case the value is known to be zero?

Oh, sure. If the value is zero then I would've expected it to be 
optimized anyhow, but there's no harm in adding that case.

Nick