[llvm-commits] [llvm] r88830 - in /llvm/trunk: lib/Transforms/Scalar/InstructionCombining.cpp test/Transforms/InstCombine/compare-signs.ll

Duncan Sands baldrick at free.fr
Sun Nov 15 01:13:26 PST 2009


Hi Nick,

> +      if (KnownZeroLHS.countLeadingOnes() == BitWidth-1 &&
> +          KnownZeroRHS.countLeadingOnes() == BitWidth-1) {

don't you want >= here, in case the value is known to be zero?

Ciao,

Duncan.



More information about the llvm-commits mailing list