[llvm-commits] [llvm] r78514 - in /llvm/trunk/lib/Target/ARM: ARMInstrInfo.td ARMInstrNEON.td ARMInstrThumb.td ARMInstrThumb2.td AsmPrinter/ARMAsmPrinter.cpp

[Bob Wilson]

On Aug 8, 2009, at 10:01 PM, Anton Korobeynikov wrote:

> Hi, Bob
>
>> I have a vague idea of what Daniel's thinking, but I'm not sure I get
>> it.  It is kind of weird to have "lane_cst" and "printLaneOperand"  
>> for
>> things that have nothing to do with Neon lanes.  Maybe it would be
>> better to keep the "no_hash" name instead of "lane"?  Somehow I
>> suspect that would defeat the purpose.
> Yeah, I also raised such questions. Better naming is always welcome :)
>
> Currently we need to print imm's w/o hashes for:
> 1. lanes
> 2. some inline asm constraints
> 3. for some weird cases when we're constructing some unique name 'on  
> fly'

I renamed the "lane_cst" operand to "nohash_imm".  That seems to me  
like a better fit for the current usage.