[llvm-commits] [llvm] r74564 - in /llvm/trunk: include/llvm/CodeGen/ include/llvm/Target/ lib/CodeGen/ lib/Target/ARM/ lib/Target/ARM/AsmPrinter/ lib/Target/Alpha/ lib/Target/Alpha/AsmPrinter/ lib/Target/CellSPU/ lib/Target/CellSPU/AsmPrinter/ lib/Target/IA64/ lib/Target/IA64/AsmPrinter/ lib/Target/MSP430/ lib/Target/Mips/ lib/Target/Mips/AsmPrinter/ lib/Target/PIC16/ lib/Target/PowerPC/ lib/Target/PowerPC/AsmPrinter/ lib/Target/Sparc/ lib/Target/Sparc/AsmPrinter/ lib/Target/X86/ lib/Target/X86/AsmPrinter/ lib/Target/X...

Chris Lattner clattner at apple.com
Thu Jul 2 09:06:21 PDT 2009


On Jul 2, 2009, at 12:18 AM, Bill Wendling wrote:

>>
>> Nice, thank you for doing this Bill.  Please document very clearly  
>> in the APIs that the alignment is the log2 of the alignment, not  
>> the alignment in bytes.
>>
> I added comments to this affect.

Thanks!

> Given that people are going to read the method name more than the  
> comments, should I also put Log2 in the name of the methods? I'm not  
> sure if that would be too redundant or superfluous. :-)

No, we don't need hungarian notation :)

-Chris



More information about the llvm-commits mailing list