[llvm-commits] [llvm] r74564 - in /llvm/trunk: include/llvm/CodeGen/ include/llvm/Target/ lib/CodeGen/ lib/Target/ARM/ lib/Target/ARM/AsmPrinter/ lib/Target/Alpha/ lib/Target/Alpha/AsmPrinter/ lib/Target/CellSPU/ lib/Target/CellSPU/AsmPrinter/ lib/Target/IA64/ lib/Target/IA64/AsmPrinter/ lib/Target/MSP430/ lib/Target/Mips/ lib/Target/Mips/AsmPrinter/ lib/Target/PIC16/ lib/Target/PowerPC/ lib/Target/PowerPC/AsmPrinter/ lib/Target/Sparc/ lib/Target/Sparc/AsmPrinter/ lib/Target/X86/ lib/Target/X86/AsmPrinter/ lib/Target/X...

[Bill Wendling]

On Jun 30, 2009, at 10:31 PM, Chris Lattner wrote:

> On Jun 30, 2009, at 3:38 PM, Bill Wendling wrote:
>
>> Author: void
>> Date: Tue Jun 30 17:38:32 2009
>> New Revision: 74564
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=74564&view=rev
>> Log:
>> Add an "alignment" field to the MachineFunction object. It makes  
>> more sense to
>> have the alignment be calculated up front, and have the back-ends  
>> obey whatever
>> alignment is decided upon.
>
> Nice, thank you for doing this Bill.  Please document very clearly  
> in the APIs that the alignment is the log2 of the alignment, not the  
> alignment in bytes.
>
I added comments to this affect. Given that people are going to read  
the method name more than the comments, should I also put Log2 in the  
name of the methods? I'm not sure if that would be too redundant or  
superfluous. :-)

-bw