[llvm-commits] [llvm] r74549 - in /llvm/trunk: lib/Target/ARM/ARMCodeEmitter.cpp lib/Target/ARM/ARMConstantIslandPass.cpp lib/Target/ARM/ARMInstrInfo.cpp lib/Target/ARM/ARMInstrThumb2.td test/CodeGen/Thumb2/thumb2-jumptbl.ll

[David Goodwin]

Perhaps, though we are not always interested in all jump table  
opcodes. For instance, the code you show is not checking for all the  
jump table opcodes, there are also the move versions BR_JTm and  
t2BR_JTm.

David

On Jun 30, 2009, at 12:56 PM, Anton Korobeynikov wrote:

> Hi David
>
>> -  if (TID.Opcode == ARM::BR_JTr || TID.Opcode == ARM::BR_JTadd) {
>> +  if (TID.Opcode == ARM::BR_JTr || TID.Opcode == ARM::BR_JTadd ||
>> +      TID.Opcode == ARM::t2BR_JTr || TID.Opcode ==  
>> ARM::t2BR_JTadd) {
> Seeing all this - maybe it will make sense to factor out such code in
> separate predicate? E.g. isJumpTableOpcode(), etc?
>
> -- 
> With best regards, Anton Korobeynikov
> Faculty of Mathematics and Mechanics, Saint Petersburg State  
> University
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits