[llvm-commits] [llvm] r74549 - in /llvm/trunk: lib/Target/ARM/ARMCodeEmitter.cpp lib/Target/ARM/ARMConstantIslandPass.cpp lib/Target/ARM/ARMInstrInfo.cpp lib/Target/ARM/ARMInstrThumb2.td test/CodeGen/Thumb2/thumb2-jumptbl.ll

Anton Korobeynikov anton at korobeynikov.info
Tue Jun 30 12:56:51 PDT 2009


Hi David

> -  if (TID.Opcode == ARM::BR_JTr || TID.Opcode == ARM::BR_JTadd) {
> +  if (TID.Opcode == ARM::BR_JTr || TID.Opcode == ARM::BR_JTadd ||
> +      TID.Opcode == ARM::t2BR_JTr || TID.Opcode == ARM::t2BR_JTadd) {
Seeing all this - maybe it will make sense to factor out such code in
separate predicate? E.g. isJumpTableOpcode(), etc?

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University




More information about the llvm-commits mailing list