[llvm-commits] [llvm] r68120 - in /llvm/trunk: lib/Transforms/Utils/InlineFunction.cpp test/Other/2009-03-31-CallGraph.ll

Chris Lattner clattner at apple.com
Tue Mar 31 15:54:21 PDT 2009


On Mar 31, 2009, at 2:33 PM, Duncan Sands wrote:

> Hi Devang,
>
>> +            // We should be able to do this:
>> +            //   (*CG)[Caller]->replaceCallSite(CI, II);
>> +            // but that fails if the old call site isn't in the  
>> call graph,
>> +            // which, because of LLVM bug 3601, it sometimes isn't.
>
> wouldn't it be better to fix PR3601?

Incidentally, converting CallGraph to use AssertingVH would be a great  
way to flush out these sorts of bugs.

-Chris




More information about the llvm-commits mailing list