[llvm-commits] [llvm] r61540 - in /llvm/trunk/utils/unittest/googletest: Makefile README.LLVM gtest-all.cc gtest-death-test.cc gtest-internal-inl.h gtest-test-part.cc gtest.cc gtest_main.cc include/gtest/internal/gtest-internal-inl.h

[Misha Brukman]

2009/1/5 John Criswell <criswell at cs.uiuc.edu>

> 1) Can you move the copyright/license information to a LICENSE.TXT file
> and add an entry in llvm/LICENSE.TXT? This is the established convention
> for third party licenses and makes it easier to find what code has
> additional licenses.


It was already listed in llvm/LICENSE.TXT and referred to the file COPYING
in this directory, but since you insist, I renamed it to LICENSE.TXT .


> 2) The code doesn't compile on my Linux machine. I get the following
> errors with g++ 4.1.2.:
>
>
> /home/vadve/criswell/src/llvm22/utils/unittest/googletest/include/gtest/internal/gtest-port.h:327:21:
> warning: tr1/tuple: No such file or directory
>
> /home/vadve/criswell/src/llvm22/utils/unittest/googletest/include/gtest/internal/gtest-param-util-generated.h:2670:
> error: 'tr1' is not a member of 'std'
>
> /home/vadve/criswell/src/llvm22/utils/unittest/googletest/include/gtest/internal/gtest-param-util-generated.h:2670:
> error: 'tr1' is not a member of 'std'
>
> /home/vadve/criswell/src/llvm22/utils/unittest/googletest/include/gtest/internal/gtest-param-util-generated.h:2670:
> error: template argument 1 is invalid
>
> Do you know what the problem might be?


Hmm, this might mean we need to run gtest's configure script to let it
define the pre-processor tokens appropriately.  I'll look into this.
FWIW, unittests compile and run fine under gcc 4.1.1, but I don't have gcc
4.1.2 installed locally.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090105/86421ebc/attachment.html>