[llvm-commits] [llvm] r61540 - in /llvm/trunk/utils/unittest/googletest: Makefile README.LLVM gtest-all.cc gtest-death-test.cc gtest-internal-inl.h gtest-test-part.cc gtest.cc gtest_main.cc include/gtest/internal/gtest-internal-inl.h

[John Criswell]

Dear Misha,

1) Can you move the copyright/license information to a LICENSE.TXT file 
and add an entry in llvm/LICENSE.TXT? This is the established convention 
for third party licenses and makes it easier to find what code has 
additional licenses.

2) The code doesn't compile on my Linux machine. I get the following 
errors with g++ 4.1.2.:

/home/vadve/criswell/src/llvm22/utils/unittest/googletest/include/gtest/internal/gtest-port.h:327:21: 
warning: tr1/tuple: No such file or directory
/home/vadve/criswell/src/llvm22/utils/unittest/googletest/include/gtest/internal/gtest-param-util-generated.h:2670: 
error: ‘tr1’ is not a member of ‘std’
/home/vadve/criswell/src/llvm22/utils/unittest/googletest/include/gtest/internal/gtest-param-util-generated.h:2670: 
error: ‘tr1’ is not a member of ‘std’
/home/vadve/criswell/src/llvm22/utils/unittest/googletest/include/gtest/internal/gtest-param-util-generated.h:2670: 
error: template argument 1 is invalid

Do you know what the problem might be?

-- John T.

Misha Brukman wrote:
> Author: brukman
> Date: Wed Dec 31 20:05:43 2008
> New Revision: 61540
>
> URL: http://llvm.org/viewvc/llvm-project?rev=61540&view=rev
> Log:
> * Removed gtest-all.cc; .cc files including other .cc files is weird
> * Removed gtest_main.cc: we have our own main() elsewhere
> * Simplified the Makefile as we don't need SOURCES
>
> * Moved the internal header to gtest/internal/
> * Simplified the Makefile to remove -I param to CPP.Flags
>
> * Updated README.LLVM with all the steps I took to massage GTest to
>   work in LLVM so far
>
> Added:
>     llvm/trunk/utils/unittest/googletest/include/gtest/internal/gtest-internal-inl.h
> Removed:
>     llvm/trunk/utils/unittest/googletest/gtest-all.cc
>     llvm/trunk/utils/unittest/googletest/gtest-internal-inl.h
>     llvm/trunk/utils/unittest/googletest/gtest_main.cc
> Modified:
>     llvm/trunk/utils/unittest/googletest/Makefile
>     llvm/trunk/utils/unittest/googletest/README.LLVM
>     llvm/trunk/utils/unittest/googletest/gtest-death-test.cc
>     llvm/trunk/utils/unittest/googletest/gtest-test-part.cc
>     llvm/trunk/utils/unittest/googletest/gtest.cc
>
> Modified: llvm/trunk/utils/unittest/googletest/Makefile
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/unittest/googletest/Makefile?rev=61540&r1=61539&r2=61540&view=diff
>
>