[llvm-commits] [llvm] r57342 - in /llvm/trunk: include/llvm/Analysis/EscapeAnalysis.h lib/Analysis/EscapeAnalysis.cpp

[Owen Anderson]

On Oct 10, 2008, at 9:58 AM, Devang Patel wrote:
>> +
>> +#ifndef LLVM_ANALYSIS_LOOPVR_H
>> +#define LLVM_ANALYSIS_LOOPVR_H
>
> cut-n-pasto :)

Fixed.

>> +    // FIXME: Are there any other possible escape points?
>
> Inline asm ?

They get treated as calls, I thought?

>> +    for (Instruction::use_iterator UI = curr->use_begin(), UE =
>> curr->use_end();
>> +         UI != UE; ++UI)
>
> This won't work when curr is a Block.
>

Why not?  Blocks are used by PHINodes, right?

Thanks for the feedback!

--Owen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2624 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20081010/bd3e7a7a/attachment.bin>