[llvm-commits] DebugInfoBuilder

[Anton Korobeynikov]

> Sorry about the delay in reviewing the patch. I have been away. I  
> think this looks good. Anton, what do you say?
Oh, I'm sorry, I thought I answered to this e-mail.

Overall patch looks ok for me. But I'd strongly suggest to change the
names again to be consistent with usual LLVM naming:

+    // Create an anchor with the specified tag.
+    GlobalVariable * CreateAnchor(unsigned anchorTag, const char *
anchorName);
+
+    // Calculate alignement for primitive types.
+    unsigned GetBasicAlignment(unsigned sizeInBits);
+
+    // Calculate the size of the specified LLVM type.
+    Constant * getSize(const Type * type);
+
+    // Calculate the alignment of the specified LLVM type.
+    Constant * getAlignment(const Type * type);
CreateAnchor => createAnchor, GetBasicAlignment => getBasicAlignment,
etc.

-- 
With best regards, Anton Korobeynikov.

Faculty of Mathematics & Mechanics, Saint Petersburg State University.