[llvm-commits] DebugInfoBuilder

[Evan Cheng]

Sorry about the delay in reviewing the patch. I have been away. I  
think this looks good. Anton, what do you say?

Evan

On Aug 11, 2008, at 5:25 PM, Talin wrote:

> OK I cleaned up the > 80 lines and renamed the methods as suggested.
>
> With regards to the LLVMDebugVersion constants - I merely copied  
> those from MachineModuleInfo, I have no idea what the various  
> version numbers correspond to.
>
> The problem with the debug version constants is that they are buried  
> inside of the CodeGen module, and I didn't want to create a  
> dependency from the Support module to the CodeGen module. Ideally,  
> those constants should be relocated to some header file where both  
> CodeGen and Support can access them. However, I don't know where  
> that would be. So in the mean time I've merely copied the  
> definitions until a decision is made.
>
> On the issue of ConstantStruct::get() and SmallVector: The way I  
> tend to design APIs is to take either a begin/end iterator or a  
> begin/end pointer. That allows you to use either a regular vector or  
> a SmallVector with the same API call. (Pointers are probably more  
> correct, although I have noticed that gcc lets you intermix pointers  
> from differently-sized SmallVectors without complaint.)
>
> -- 
> -- Talin
> <DIB.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits