[llvm-commits] atomics memoperands patch

Chris Lattner clattner at apple.com
Tue Jun 24 11:03:58 PDT 2008


On Jun 20, 2008, at 12:28 AM, Evan Cheng wrote:

>
> Do we need the if () else if? AddNodeIDNode has already added those
> fields to the FoldingSetNodeId.
>
> Also, do we want to cse nodes that are volatile?

FYI, CSE'ing nodes that are volatile is *required*.  If they are  
different loads and volatile they should have different chain inputs.   
If all inputs are the same (including the chain) they should  
definitely be CSE'd.

-Chris



More information about the llvm-commits mailing list