[llvm-commits] paths on win32

[Nick Lewycky]

Anton Korobeynikov wrote:
> Hi, Nick
> 
>> This patch moves the constructor implementations out of 
>> include/llvm/System/Path.h and into lib/System/*/Path.inc. This fixes 
>> the bug, but there may be a small price in efficiency. Is this approach 
>> okay? (There are two other ways to fix the bug.)
> Patch looks ok for me, please apply.

Thanks!

> Why do you need this hunk, btw?:
> 
>  std::string Path::getDirname() const {
> -  return getDirnameCharSep(path, '\\');
> +  return getDirnameCharSep(path, '/');
>  }
> 

It's not needed for this change, but I'm quite sure it's a bug. "path" 
ought to never include \ after this change is in, so searching for \ 
doesn't make a whole lot of sense.

Nick