[llvm-commits] paths on win32

Anton Korobeynikov asl at math.spbu.ru
Sun May 11 04:21:16 PDT 2008


Hi, Nick

> This patch moves the constructor implementations out of 
> include/llvm/System/Path.h and into lib/System/*/Path.inc. This fixes 
> the bug, but there may be a small price in efficiency. Is this approach 
> okay? (There are two other ways to fix the bug.)
Patch looks ok for me, please apply.

Why do you need this hunk, btw?:

 std::string Path::getDirname() const {
-  return getDirnameCharSep(path, '\\');
+  return getDirnameCharSep(path, '/');
 }

-- 
With best regards, Anton Korobeynikov.

Faculty of Mathematics & Mechanics, Saint Petersburg State University.





More information about the llvm-commits mailing list