[llvm-commits] [llvm-gcc-4.2] r49015 - in /llvm-gcc-4.2/trunk/gcc: config/i386/llvm-i386-target.h llvm-abi.h

[Evan Cheng]

I agree with Dale. While the implementation of the hook currently  
checks for single element struct, it doesn't have to stay that way.  
The former name more clearly spells out its semantics in my opinion.

Evan

On Apr 1, 2008, at 9:14 AM, Devang Patel wrote:

>
> On Mar 31, 2008, at 8:29 PM, Dale Johannesen wrote:
>> On Mar 31, 2008, at 7:02 PM, Devang Patel wrote:
>>
>>> Author: dpatel
>>> Date: Mon Mar 31 21:02:44 2008
>>> New Revision: 49015
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=49015&view=rev
>>> Log:
>>> s/LLVM_SHOULD_RETURN_STRUCT_AS_SCALAR/
>>> LLVM_SHOULD_RETURN_SELT_STRUCT_AS_SCALAR/g
>>
>> I don't like this one.  Structs that are returned as scalars are not,
>> in fact, always single-element.
>
> True, but this hook explicitly checks single-element. So it is a  
> good idea to rename the hook to make this clear.
>
> -
> Devang
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20080401/6c1ba62b/attachment.html>