<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">I agree with Dale. While the implementation of the hook currently checks for single element struct, it doesn't have to stay that way. The former name more clearly spells out its semantics in my opinion.<div><br></div><div>Evan</div><div><br><div><html>On Apr 1, 2008, at 9:14 AM, Devang Patel wrote:</html><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div>On Mar 31, 2008, at 8:29 PM, Dale Johannesen wrote:<br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; ">On Mar 31, 2008, at 7:02 PM, Devang Patel wrote:<br><br><blockquote type="cite">Author: dpatel<br></blockquote><blockquote type="cite">Date: Mon Mar 31 21:02:44 2008<br></blockquote><blockquote type="cite">New Revision: 49015<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=49015&view=rev">http://llvm.org/viewvc/llvm-project?rev=49015&view=rev</a><br></blockquote><blockquote type="cite">Log:<br></blockquote><blockquote type="cite">s/LLVM_SHOULD_RETURN_STRUCT_AS_SCALAR/<span class="Apple-converted-space"> </span><br></blockquote><blockquote type="cite">LLVM_SHOULD_RETURN_SELT_STRUCT_AS_SCALAR/g<br></blockquote><br>I don't like this one. Structs that are returned as scalars are not, <br>in fact, always single-element.<br></span></blockquote></div><br><div>True, but this hook explicitly checks single-element. So it is a good idea to rename the hook to make this clear.</div><div><br></div><div>-</div><div>Devang</div></div>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></div></body></html>