[llvm-commits] [PATCH] Expose ExecutionEngine::getTargetData() to c and ocaml bindings.

[Gordon Henriksen]

On Mar 25, 2008, at 01:00, Erick Tryzelaar wrote:

> Another api call the kaleidoscope tutorial calls that I missed.
> ---
> bindings/ocaml/executionengine/Makefile            |    2 +-
> .../ocaml/executionengine/llvm_executionengine.ml  |    3 +++
> .../ocaml/executionengine/llvm_executionengine.mli |    4 ++++
> include/llvm-c/ExecutionEngine.h                   |    3 +++
> lib/ExecutionEngine/ExecutionEngineBindings.cpp    |    4 ++++
> 5 files changed, 15 insertions(+), 1 deletions(-)

Add an test to test/Bindings/Ocaml/target.ml please.

> +  (** [target_data ee] returns the target data for the given  
> execution engine
> +      [ee]. *)
> +  val target_data: t -> Llvm_target.TargetData.t

For style and to clarify memory management I would suggest:

[target_data ee] is the target data owned by the execution engine [ee].

Otherwise looks great.

— Gordon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20080325/040eb073/attachment.html>