<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><html>On Mar 25, 2008, at 01:00, Erick Tryzelaar wrote:</html><br class="Apple-interchange-newline"><blockquote type="cite">Another api call the kaleidoscope tutorial calls that I missed.<br>---<br><font class="Apple-style-span" color="#004FAF" face="'Andale Mono'"><span class="Apple-style-span" style="background-color: transparent;"> bindings/ocaml/executionengine/Makefile | 2 +-<br> .../ocaml/executionengine/llvm_executionengine.ml | 3 +++<br> .../ocaml/executionengine/llvm_executionengine.mli | 4 ++++<br> include/llvm-c/ExecutionEngine.h | 3 +++<br> lib/ExecutionEngine/ExecutionEngineBindings.cpp | 4 ++++<br></span></font> 5 files changed, 15 insertions(+), 1 deletions(-)<br></blockquote><br></div><div>Add an test to test/Bindings/Ocaml/target.ml please.</div><div><br></div><div><blockquote type="cite" class=""><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal 'Andale Mono'; "><span class="Apple-style-span" style="font-size: 12px; -webkit-text-stroke-width: -1; ">+ (** [target_data ee] returns the target data for the given execution engine</span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal 'Andale Mono'; ">+ [ee]. *)</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal 'Andale Mono'; ">+ val target_data: t -> Llvm_target.TargetData.t</div></blockquote><div><font class="Apple-style-span" color="#000000"><span class="Apple-style-span" style="background-color: transparent;"><br></span></font></div><div>For style and to clarify memory management I would suggest:</div><div><br></div></div><blockquote class="webkit-indent-blockquote" style="margin: 0 0 0 40px; border: none; padding: 0px;">[target_data ee] is the target data owned by the execution engine [ee].</blockquote><div><br></div><div>Otherwise looks great.</div><div><font class="Apple-style-span" color="#000000"><span class="Apple-style-span" style="background-color: transparent;"><br></span></font><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal 'Andale Mono'; "><span class="Apple-style-span" style="-webkit-text-stroke-width: -1px; "><font class="Apple-style-span" color="#000000" face="'Trebuchet MS'" size="3"><span class="Apple-style-span" style="background-color: transparent; font-size: 12px;">— Gordon</span></font></span></div></div><div apple-content-edited="true"><font class="Apple-style-span" color="#000000"><span class="Apple-style-span" style="background-color: transparent;"> </span></font></div><br></body></html>