[llvm-commits] [llvm] r47895 - in /llvm/trunk: include/llvm/DerivedTypes.h lib/VMCore/Type.cpp

Chris Lattner clattner at apple.com
Tue Mar 4 13:17:09 PST 2008


>>> URL: http://llvm.org/viewvc/llvm-project?rev=47895&view=rev
>>> Log:
>>> Add FunctionType ctor variant that takes SmallVector params.
>>>
>>>
>>> #include "llvm/Type.h"
>>> +#include "llvm/ADT/SmallVector.h"
>>
>> Instead of making this specific to smallvector, how about passing in
>> pointer to pointer + count instead?  That eliminates the #include and
>> allows it to work with arrays on the stack and scalars.
>
> I will do that conversion also. I did not do it immediately because it
> required many mechanical changes.

Just start using it where you would use the smallvector one, other  
existing clients don't need to change.  I'd really like to avoid  
DerivedTypes.h #including SmallVector.

-Chris



More information about the llvm-commits mailing list