[llvm-commits] [llvm] r47895 - in /llvm/trunk: include/llvm/DerivedTypes.h lib/VMCore/Type.cpp

Devang Patel dpatel at apple.com
Tue Mar 4 11:41:41 PST 2008


On Mar 4, 2008, at 11:30 AM, Chris Lattner wrote:

>
> On Mar 4, 2008, at 10:57 AM, Devang Patel wrote:
>
>> Author: dpatel
>> Date: Tue Mar  4 12:57:05 2008
>> New Revision: 47895
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=47895&view=rev
>> Log:
>> Add FunctionType ctor variant that takes SmallVector params.
>>
>>
>> #include "llvm/Type.h"
>> +#include "llvm/ADT/SmallVector.h"
>
> Instead of making this specific to smallvector, how about passing in
> pointer to pointer + count instead?  That eliminates the #include and
> allows it to work with arrays on the stack and scalars.

I will do that conversion also. I did not do it immediately because it  
required many mechanical changes.
-
Devang






More information about the llvm-commits mailing list