[llvm-bugs] [Bug 46159] New: clang-format believes "try" is a keyword in a C file.

via llvm-bugs llvm-bugs at lists.llvm.org
Mon Jun 1 08:47:17 PDT 2020


https://bugs.llvm.org/show_bug.cgi?id=46159

            Bug ID: 46159
           Summary: clang-format believes "try" is a keyword in a C file.
           Product: clang
           Version: 10.0
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P
         Component: Formatter
          Assignee: unassignedclangbugs at nondot.org
          Reporter: phil at kantaka.co.uk
                CC: djasper at google.com, klimek at google.com,
                    llvm-bugs at lists.llvm.org

When formatting this snippet (taken from fs/proc/kcore.c in the Linux kernel):

static size_t get_kcore_size(int *nphdr, size_t *phdrs_len, size_t *notes_len,
                             size_t *data_offset)
{
        size_t try, size;
        struct kcore_list *m;

        *nphdr = 1; /* PT_NOTE */
        size = 0;

        list_for_each_entry(m, &kclist_head, list) {
                try = kc_vaddr_to_offset((size_t)m->addr + m->size);
                if (try1 > size)
                        size = try1;
                *nphdr = *nphdr + 1;
        }
}

clang-format-10 formats it as:

static size_t get_kcore_size(int *nphdr, size_t *phdrs_len, size_t *notes_len,
                             size_t *data_offset) {
  size_t try
    , size;
  struct kcore_list *m;

  *nphdr = 1; /* PT_NOTE */
  size = 0;

  list_for_each_entry(m, &kclist_head, list) {
    try
      = kc_vaddr_to_offset((size_t)m->addr + m->size);
    if (try > size)
      size = try
        ;
    *nphdr = *nphdr + 1;
  }
}

Renaming "try" to "try1" fixes the layout. I suspect clang-format thinks "try"
is a keyword even in a C file.



Renaming "try" to "try1" fixes the formatting:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20200601/051b6948/attachment.html>


More information about the llvm-bugs mailing list